feat(protocol): publish effective terminal geometry - #137
Closed
schickling-assistant wants to merge 1 commit into
Closed
feat(protocol): publish effective terminal geometry#137schickling-assistant wants to merge 1 commit into
schickling-assistant wants to merge 1 commit into
Conversation
agent-session-id: ed878dac-3735-4276-b3e0-ea1b1cd65291 agent-tool: Codex CLI agent-tool-version: 0.145.0 agent-model: unknown agent-runtime-profile: /nix/store/mnx8agbdq3wiyb6vz63lhgscgazkrn98-coding-agent-runtime-profile/share/coding-agents/profile.json agent-skills-manifest: /nix/store/5r69m9k2llmri3na81518zx0a7y0d3cn-agent-skills-corpus/share/agent-skills/manifest.json tooling-profile: dotfiles@0fb7e03
Contributor
Author
|
Closing as a duplicate of #135, which implements the same ordered effective-geometry protocol direction with stronger real-PTY validation. Keeping this branch available for its compatibility and client-state test evidence. Posted on behalf of @schickling
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #134.
Why
Programmatic clients advertise a requested size but currently cannot observe the daemon effective min-wins geometry before width-sensitive output. This is a longstanding embedding capability gap, not a regression in resize negotiation.
What
GEOMETRYpacketSCREENDATAwhen peers attach, resize, or detachSessionConnectiongeometry eventSessionandattachPty()so effective changes do not feed back as new resize requestsThe daemon min-wins policy is unchanged. The human CLI remains unchanged and may ignore the additive packet.
Compatibility
SCREENwithout a precedingGEOMETRYScope
This establishes the ordered protocol and JavaScript embedding surfaces. Consumers that wrap
pty attachthrough its terminal byte stream still need a separately framed CLI transport before they can consume geometry metadata without corrupting terminal output.Validation
SessionConnection, testingSession, andattachPty()compatibility/no-feedback testsThe PR is intentionally draft while the complete upstream suite and CI are checked.
Posted on behalf of @schickling
agent_nameagent_session_idagent_toolagent_tool_versionagent_runtimeagent_modelruntime_profileskills_manifestworktreemachinetooling_profile