Allow duplicate display names with unambiguous resolution - #139
Merged
Conversation
This was referenced Jul 31, 2026
myobie
marked this pull request as ready for review
July 31, 2026 11:27
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Display names are mutable presentation metadata, so requiring global uniqueness makes harmless relabeling an identity operation. Stable session IDs already provide the durable identity needed by automation.
Part of compoundingtech/st2#128.
What
Validation
npm run typecheck- passnpm run build- passCI=1 ./node_modules/.bin/vitest run tests/display-name.test.ts tests/remote-fabric.test.ts tests/up-name-decouple.test.ts- 59/59 passCI=1 npm test- 1,471 pass, 20 skip, 4 unrelated environment failures: zsh is absent; Vim resolves to Neovim 0.12.3 and Nano 9.0 renders different text than the screenshot expectationsnpm run verify-docs- 12/13 pass; the Vim example hits the same Neovim text mismatch