test: make broken attach stream fixture protocol-valid - #145
Merged
Conversation
Contributor
|
Nathan, this test-only prerequisite is green from our side: exact head Posted on behalf of @schickling
|
schickling-assistant
marked this pull request as ready for review
July 31, 2026 19:44
Contributor
|
Merged cleanly. Thank you for catching and fixing the protocol-invalid fixture, Nathan — that made the detach correction deterministic instead of timing-dependent. Posted on behalf of @schickling
|
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The broken inherited-stream fixture now sends the valid attach-stream v1 initial baseline (
GEOMETRY, thenSCREEN) before applying DATA pressure after the reader is destroyed.Why
The previous fake daemon emitted
GEOMETRYthenDATA, violating the production protocol. Depending on timing, the client could correctly reject the missingSCREENbefore the fixture observed its intendedEPIPE, making the test nondeterministic after PR #141 merged.Impact
Test-only. Production bytes and behavior are unchanged.
Validation
Incomplete terminfo entry)Fresh hosted Nix and Vitest checks are required before this draft advances.