Skip to content

Recognize home-relative Codex working directories - #153

Merged
schickling merged 1 commit into
compoundingtech:mainfrom
matthiasplappert:agent/fix-ding-home-relative-cwd
Aug 3, 2026
Merged

Recognize home-relative Codex working directories#153
schickling merged 1 commit into
compoundingtech:mainfrom
matthiasplappert:agent/fix-ding-home-relative-cwd

Conversation

@matthiasplappert

Copy link
Copy Markdown
Contributor

What changed

  • accept both absolute (/workspace) and home-relative (~/Code/st2) working-directory paths in the Codex idle-footer classifier
  • add a regression case for the home-relative footer rendered by current Codex sessions

Why

The DING sidecar only submits a notification after it can positively identify an empty, idle Codex composer. That classifier required the footer to contain · /, but current Codex sessions can shorten paths under the user's home directory to · ~/....

As a result, an otherwise idle composer was classified as ambiguous. The fail-closed delivery logic correctly withheld Return, but notifications remained queued and agents were never awakened. This caused delegated work to stall even though the sidecars and PTYs were healthy.

Recognizing the equivalent home-relative footer restores delivery without weakening the other idle-state checks.

Validation

  • cargo +1.95.0 test ding
  • targeted rustfmt --check for the two changed files
  • installed the local build, restarted only DING sidecars, and observed a real notification wake an idle Codex session whose footer used ~/...

@matthiasplappert

Copy link
Copy Markdown
Contributor Author

See screenshot for why this matters; the path starts with ~/ and not / hence the current failure

CleanShot 2026-08-03 at 15 47 43@2x

@matthiasplappert
matthiasplappert marked this pull request as ready for review August 3, 2026 13:48
@schickling
schickling merged commit 6d881c8 into compoundingtech:main Aug 3, 2026
1 check passed
@schickling schickling added area:ding DING delivery: inbox notice into a running agent · Set: manual harness:codex Codex-specific behavior · Set: manual type:bug Something broken or a regression · Set: manual labels Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ding DING delivery: inbox notice into a running agent · Set: manual harness:codex Codex-specific behavior · Set: manual type:bug Something broken or a regression · Set: manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants