fix(watch): bound sidecar delivery watches away from Resource payloads - #335
Merged
schickling-assistant merged 1 commit intoAug 25, 2026
Conversation
schickling-assistant
marked this pull request as ready for review
August 24, 2026 21:18
Contributor
Author
|
@codex Please review this PR. Posted on behalf of @schickling
|
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The DING sidecar and the codex/opencode delivery pumps recursively watched each agent dir. A recursive registration eagerly allocates one inotify watch per directory BEFORE any callback filtering, and agent dirs contain `resources/` payload trees — the same unbounded-traversal class the supervisor hit in #314, one level down. - watch_delivery_inputs now makes two shallow subscriptions: a non-recursive watch on the agent dir (status file) plus a recursive watch on resources/inbox, which is st2-owned and bounded by delivery traffic rather than payloads. - run_ding anchors its watch on the inbox itself and creates it up front, instead of falling back to a recursive walk over the whole agent dir when the inbox did not exist yet. - All remaining recursive registrations construct their watcher with follow_symlinks(false): a symlink must never carry traversal outside the watched boundary. Closes #314 (sidecar instance). Co-authored-by: schickling-assistant <schickling-assistant@users.noreply.github.com> agent-identity: unknown agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.3 agent-runtime: OMP 18.0.3 tooling-profile: dotfiles@f33cd9c-dirty
schickling-assistant
force-pushed
the
schickling-assistant/issue314-2-sidecar-watches
branch
from
August 25, 2026 06:27
11bcf5d to
197a84a
Compare
schickling-assistant
deleted the
schickling-assistant/issue314-2-sidecar-watches
branch
August 25, 2026 07:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DING sidecar and the codex/opencode delivery pumps recursively
watched each agent dir. A recursive registration eagerly allocates one
inotify watch per directory BEFORE any callback filtering, and agent dirs
contain
resources/payload trees — the same unbounded-traversal classthe supervisor hit in #314, one level down.
non-recursive watch on the agent dir (status file) plus a recursive
watch on resources/inbox, which is st2-owned and bounded by delivery
traffic rather than payloads.
instead of falling back to a recursive walk over the whole agent dir
when the inbox did not exist yet.
follow_symlinks(false): a symlink must never carry traversal outside
the watched boundary.
Closes #314 (sidecar instance).
Co-authored-by: schickling-assistant schickling-assistant@users.noreply.github.com
agent-identity: unknown
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.0.3
agent-runtime: OMP 18.0.3
tooling-profile: dotfiles@f33cd9c-dirty
Stack created with GitHub Stacks CLI • Give Feedback 💬