Skip to content

Implement immutable agent IDs and mutable addresses coherently #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
schickling-assistant wants to merge 5 commits into from
Closed

Implement immutable agent IDs and mutable addresses coherently #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ea6a44
feat(identity): separate immutable agent IDs from addresses
schickling-assistant Sep 5, 2026
c76ccb4
fix(identity): remove duplicate supervisor wake test
schickling-assistant Sep 5, 2026
7d09ed9
fix(identity): use exact IDs in generated driver argv
schickling-assistant Sep 5, 2026
9119a38
test(identity): align legacy supervisor edge coverage
schickling-assistant Sep 5, 2026
0218a32
fix(identity): separate subject and external actor tags
schickling-assistant Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions INVARIANTS.md
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions crates/agent-spec/src/discovery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,12 @@ fn unobservable_entry_may_hide_declaration(
/// gain fields without breaking readers.
#[derive(Debug, Clone, Default, PartialEq, Eq)]
pub struct Declared {
/// `id` as written in the file. `None` for an unmigrated legacy declaration.
pub id: Option<String>,
/// `identity` as written in the file. `None` when the file relies on [`path_defaults`].
pub identity: Option<String>,
/// `address` as written in the file. `None` when the positional identity is the fallback.
pub address: Option<String>,
/// `host` as written in the file. `None` when the file relies on [`path_defaults`].
pub host: Option<String>,
/// `type` as written, before it is normalized to `JobType::Service`. `None` when unset.
Expand All @@ -343,6 +347,8 @@ pub struct Declared {
impl From<&RawSpec> for Declared {
fn from(raw: &RawSpec) -> Self {
Self {
id: raw.id.clone(),
address: raw.address.clone(),
identity: raw.identity.clone(),
host: raw.host.clone(),
job_type: raw.job_type.clone(),
Expand Down
Loading
Loading