fix: restore short runtime observation containment - #87
Merged
schickling-assistant merged 1 commit intoJul 30, 2026
Merged
Conversation
PR #78 promoted a consumer timeout into a fleet-scalability contract. Restore the two-second outer bound and remove its synthetic fixed-sleep proof while retaining the portable hung-process fixture. Fleet behavior is proved against the packaged runtime in PR #84. Pure exact-ID observation remains the R19 architecture rather than a larger global-census timeout. agent-session-id: dev3.dotfiles-cos-misc-agent-runtime-simplification agent-tool: Codex agent-tool-version: 0.145.0 agent-model: gpt-5.6-sol agent-runtime-profile: /home/schickling/.config/coding-agents/profile.json agent-skills-manifest: /nix/store/nk9iml2841l1yjjg0f6f0d3y60zkg1nn-agent-skills-corpus/share/agent-skills/manifest.json tooling-profile: dotfiles@4a0515f
schickling-assistant
marked this pull request as ready for review
July 30, 2026 12:56
schickling-assistant
deleted the
schickling-assistant/2026-07-30-restore-short-pty-bound
branch
July 30, 2026 12:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #78 turned a consumer-side timeout increase into a fleet-scalability invariant. Its 45-row test did not exercise fleet observation: the fake
ptyslept for three seconds before printing a prebuilt JSON file. The resulting 10-second deadline delayed fail-closed diagnosis without fixing the observation boundary.Goal
Keep a short outer bound around a wedged runtime, remove the synthetic latency contract, and leave fleet scalability with the runtime producer and pure exact-ID observation architecture.
Decisions
sleepin the hung-process fixture because that portability repair is independent of the timeout policy.Verification
nix develop -c cargo test --test doctor doctor_bounds_a_hung_pty_probe_and_reports_the_runtime_error -- --exact— 1 passed; the proof completed in 2.02s and observedtimed out after 2.0s.nix develop -c cargo test --test up_once_exit— 2 passed.nix develop -c cargo clippy --all-features --lib --bin st2 --test doctor --test up_once_exit -- -D warnings— passed.nix flake check --print-build-logs— all six x86_64-linux checks passed, including packaged tests and invariant-reference resolution.git diff --check— passed.nix develop -c cargo test --all-targets --all-features— affected suites passed; the run later hit the pre-existingup_materialize_only_writes_the_overlay_without_needing_ptyPATH fixture failure. The exact failure reproduces unchanged onorigin/main.cargo fmt --all -- --checkremains red on unrelated files already unformatted onmain; the changed diff is whitespace-clean.Complexity
No new complexity. This removes 71 net lines and restores the timeout as a defensive boundary.
Concerns
PR #84 also touches
tests/doctor.rs, so merge order may require a small textual rebase. The semantic contracts are complementary: #84 proves real fleet behavior; this PR removes the synthetic latency invariant.Friction & bottlenecks
git, producing a baseline failure unrelated to this change.main.Follow-ups
References
docs/vrs/requirements.mdanddocs/vrs/spec.md.