fix: make Agent Spec placement path-independent - #93
Merged
Conversation
myobie
force-pushed
the
agent/issue-88-path-independent-identity
branch
from
July 30, 2026 14:09
d7c2866 to
0872e53
Compare
myobie
marked this pull request as ready for review
July 30, 2026 14:17
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
identity+hostpair authoritative independent of declaration path while preserving path defaults and mismatch diagnostics when either field is omitted.git/.st2control directories, the catalog-root PTY registry, and state directories owned by an actual declarationContract
.managed,.retired, and nested project folders namedarchive,resources, orinboxcarry no implicit lifecycle/control meaning.gitand.st2are excluded at every hierarchy depth so nested repositories/control state cannot expose declarationsptyis excluded only at the catalog root;resources,archive, andinboxare excluded only as children of an actual declaration parentVerification at
0872e53a6aa3c4d1b356981faf91279a57821cf8nix flake check --print-build-logs: PASScargo test -p agent-spec --test discovery -- --test-threads=1: PASS (27/27)cargo test --test validate -- --test-threads=1: PASS (32/32)cargo test --lib watch::tests -- --test-threads=1: PASS (3/3)cargo test --workspace --all-targets -- --test-threads=1: PASScargo clippy --workspace --all-targets -- -D warnings: PASScargo doc --workspace --no-deps: PASS (five unchanged pre-existing warnings)git diff --check origin/main: PASSReview correction
.gitand.st2paths in both discovery and watcher classificationptyroot-only, declaration state directories contextual, and all other dot folders ordinarymaince2c1069f2a59fd50a0ca1d56346e103db666ed2, preserving PR feat(agent-spec): add typed Resource bindings #86 resource bindingsNo live catalog, supervisor, service, or PTY state was mutated.
Closes #88
Closes #90