ESEMM-28: Improvements For Contribution Fix Service #227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In one of the upgrader that was added here we fix some faulty contribution this PR adds following improvements to the process
The difference in handling of membership and non membership contributions is only while creating the line items
For memebrship contributions we try to use the price field value that is related to that particular memebership type id but if price field value is not found through membership type id relationship then we use the default contribution price field value.
For non membershsip contributions we tend to use directly the default contribution price field value.