Skip to content

ESEMM-28: Improvements For Contribution Fix Service #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shahrukh-compuco
Copy link
Contributor

@shahrukh-compuco shahrukh-compuco commented Apr 11, 2025

Overview

In one of the upgrader that was added here we fix some faulty contribution this PR adds following improvements to the process

  • Improved logging for the process
  • Fix both membership and non membership related contributions as previously it was fixing membership related contributions only
  • Improved checking for existing financial records for a contribution
  • Financial account and payment method for financial record creation are fetched from payment processor instead of hardcoded values

The difference in handling of membership and non membership contributions is only while creating the line items
For memebrship contributions we try to use the price field value that is related to that particular memebership type id but if price field value is not found through membership type id relationship then we use the default contribution price field value.

For non membershsip contributions we tend to use directly the default contribution price field value.

@shahrukh-compuco shahrukh-compuco requested a review from erawat April 11, 2025 12:09
@shahrukh-compuco shahrukh-compuco force-pushed the esemm-28-fix-financial-account branch from 91b996b to 68c1af7 Compare April 11, 2025 12:11
Copy link
Member

@erawat erawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahrukh-compuco can you add a bit more of details how non membership and membership contribution would look like in terms of financial items/entity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants