Skip to content

ASESPRT-783: Fix Status For 0 Amount Contributions #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shahrukh-compuco wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −1
Open

ASESPRT-783: Fix Status For 0 Amount Contributions #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Civi/Financeextras/Event/Listener/ContributionPaymentUpdatedListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ private static function updateContributionStatus($contributionId) {
$contribution = \Civi\Api4\Contribution::get(FALSE)
->addWhere('id', '=', $contributionId)
->addWhere('contribution_status_id:name', 'IN', $allowedStatus)
->addWhere('total_amount', '!=', 0)
->execute()
->first();

Expand Down
18 changes: 17 additions & 1 deletion tests/phpunit/Civi/Financeextras/ApiWrapper/PaymentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public static function setupBeforeClass(): void {
self::$contribution = ContributionFabricator::fabricate($contributionParams);
}

public function setUp() {
public function setUp(): void {
}

public function testMakingPartialPaymentUpdatesContributionToPartiallyPaid(): void {
Expand Down Expand Up @@ -57,4 +57,20 @@ public function testMakingFullPaymentUpdatesContributionToCompleted(): void {
$this->assertEquals('Completed', $contribution['contribution_status']);
}

public function testZeroAmountContributionIsCreatedAsCompleted(): void {
$contact = ContactFabricator::fabricate();
self::$contribution = ContributionFabricator::fabricate([
'financial_type_id' => 'Donation',
'receive_date' => date('Y-m-d'),
'total_amount' => 0.00,
'contact_id' => $contact['id'],
'payment_instrument_id' => 'Credit Card',
'currency' => 'GBP',
]);

$contribution = civicrm_api3('Contribution', 'getSingle', ['id' => self::$contribution['id']]);

$this->assertEquals('Completed', $contribution['contribution_status']);
}

}