IRS-184: Stop calling the fees api if the fees field and membership id is not present to avoid multiple calls#85
Open
kaustubh-compuco wants to merge 1 commit into7.x-5.8-patchesfrom
Conversation
…d is not present to avoid multiple calls
802ecd9 to
c1735f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the issue of multiple MembershipApi calls when there no MembershipId present or No membership field is enabled.
This PR is not exact patch as the
webform_civicrmmodule has been updated with new code, but we have added this fix in new code as well so core issues are also resolved.NOTE: We have a new release for
webform_civicrmmodule in core which has a bit of refactoring of the code and some changes. So in order to fix the core issue we have tested the latest released version of thewebform_civicrmmodule on IRS we found that the same issue exists in new chanegs.We have applied the fix according to new change done under the module, So that when we update the
webform_civicrmmodule in next release it will take the fix and new changes along with it to all clientsBefore
Membership.application.issue.webm
After
membership-form-solution.webm
Technical Details