Skip to content

IRS-184: Stop calling the fees api if the fees field and membership id is not present to avoid multiple calls#85

Open
kaustubh-compuco wants to merge 1 commit into7.x-5.8-patchesfrom
IRS-184-webform-issue-membership-application-form
Open

IRS-184: Stop calling the fees api if the fees field and membership id is not present to avoid multiple calls#85
kaustubh-compuco wants to merge 1 commit into7.x-5.8-patchesfrom
IRS-184-webform-issue-membership-application-form

Conversation

@kaustubh-compuco
Copy link

@kaustubh-compuco kaustubh-compuco commented Nov 24, 2025

Overview

This PR fixes the issue of multiple MembershipApi calls when there no MembershipId present or No membership field is enabled.

This PR is not exact patch as the webform_civicrm module has been updated with new code, but we have added this fix in new code as well so core issues are also resolved.
NOTE: We have a new release for webform_civicrm module in core which has a bit of refactoring of the code and some changes. So in order to fix the core issue we have tested the latest released version of the webform_civicrm module on IRS we found that the same issue exists in new chanegs.
We have applied the fix according to new change done under the module, So that when we update the webform_civicrm module in next release it will take the fix and new changes along with it to all clients

Before

Membership.application.issue.webm

After

membership-form-solution.webm

Technical Details

  1. Add condition for MembershipId and the fee field to check if they are present and have values then only proceed otherwise throw and error and stop Javascript flow.
  2. We are throwing an exception so that we can track back any issues and clear indication is provided. It does not stop forms from submitting.

@kaustubh-compuco kaustubh-compuco force-pushed the IRS-184-webform-issue-membership-application-form branch from 802ecd9 to c1735f4 Compare November 25, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant