Skip to content

Conversation

@constantinpape
Copy link
Contributor

No description provided.

@constantinpape constantinpape marked this pull request as draft December 14, 2025 09:29
@constantinpape constantinpape marked this pull request as ready for review December 15, 2025 08:57
@constantinpape
Copy link
Contributor Author

This PR takes care of:

  • APG for tiled embeddings
  • Refactoring of the instance segmentation functionality, including mask_data_to_segmentation, renaming get_amg, and using "instance_segmentation" as default output_mode.
  • Parallelization of the main CPU-bound processing steps in APG.

Still to address (in other PRs):

  • Mask refinement with derived box prompts
  • Switch to APG as default (in the functions and the napari GUI)
  • Check inference for large WSIs and debug / speed up if necessary
  • Update documentation to include APG in automatic segmentation CLI

cc @anwai98

Copy link
Collaborator

@anwai98 anwai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look at the scripts here, looks good to me! (didn't test the API in detail, but will do once it's close to completion)

Thanks @constantinpape 🥳

@constantinpape
Copy link
Contributor Author

Thanks for checking this out @anwai98 . I think that the more efficient segmentation is working now. I will quickly check the result tomorrow and merge this if things look as expected.

@constantinpape
Copy link
Contributor Author

The tiling result looks very good:

image

I will merge it despite the test failure, I think that one is a one-off.

@constantinpape constantinpape merged commit 4a0fe42 into automatic-prompt-generator Dec 18, 2025
5 of 6 checks passed
@constantinpape constantinpape deleted the apg-api branch December 18, 2025 08:05
@anwai98
Copy link
Collaborator

anwai98 commented Dec 18, 2025

Ahha now that's amazing! (I saw the timing improvements too) ;) Thanks @constantinpape! I'll give it a quick shot today afternoon on the WSIs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants