Migrate to Vitest#13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test migration to Vite and Vitest, as an alternative to Webpack and Jest. This allows sharing tests between Node and browser, and running them with relative ease. There is also a VS Code Dev Container definition included to help keep things better isolated during development.
The CI might fail, need to see. 😅
Edit: so using Vite for the build is not a good idea... but Vitest should still work fine.
Edit 2: Managed to fix it, so the major changes are moving to module, using Vitest, and dropping Node 18. This allows removing a whole lot of dependencies, as well as combining the browser and node tests into a single file. The recommended linting rules from upstream are also directly used. 🎉