Update static 1.2 spec - rdf-tests 348#150
Merged
Merged
Conversation
Replace the two-pass approach (decode UCHAR then ECHAR separately) with a single-pass regex that handles both in one scan. The SPARQL 1.2 spec states "the character resulting from the codepoint escape sequence is not further interpreted", so a backslash produced by \ must not be re-processed as an ECHAR prefix. Remove codepoint-esc-05-bad and codepoint-esc-06-bad negative tests that were testing the incorrect two-pass behavior. Update AST snapshots and generated SPARQL files for codepoint-esc-05 through codepoint-esc-09. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rubensworks
requested changes
Jun 19, 2026
Member
Author
|
Linking to Comunica, I confirm that the spec tests now pass in that repo. |
rubensworks
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements tests changed in w3c/rdf-tests#348