Skip to content

Add patch to URL-escape key paths in HTTP remote URLs #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yarikoptic merged 1 commit into from
Feb 13, 2026
Merged

Add patch to URL-escape key paths in HTTP remote URLs #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions patches/20260212-43a3f3aaf2-url-escape-keyUrls.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
diff --git a/Remote/Git.hs b/Remote/Git.hs
index 6b7dc77d98..4faaea082d 100644
--- a/Remote/Git.hs
+++ b/Remote/Git.hs
@@ -482,7 +482,12 @@ inAnnex' repo rmt st@(State connpool duc _ _ _ _) key
keyUrls :: GitConfig -> Git.Repo -> Remote -> Key -> [String]
keyUrls gc repo r key = map tourl locs'
where
- tourl l = Git.repoLocation repo ++ "/" ++ l
+ tourl l = Git.repoLocation repo ++ "/" ++ escapeURIString escchar l
+ -- Escape characters that are not allowed unescaped in a URI
+ -- path component, but don't escape '/' since the location
+ -- is a path with multiple components.
+ escchar '/' = True
+ escchar c = isUnescapedInURIComponent c
-- If the remote is known to not be bare, try the hash locations
-- used for non-bare repos first, as an optimisation.
locs
Loading