Fix dailies on 6/6/2026#400
Merged
Merged
Conversation
Updated tqdm usage in tests to ensure consistent ASCII output for progress bars across different environments. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Removed comments explaining ASCII bar fill for tqdm in tests.
CodyCBakerPhD
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated tqdm usage in tests to ensure consistent ASCII output for progress bars across different environments.
Source cause
The tests were always relying on a tqdm quirk:
io.StringIO(), which has no.encodingattributetqdmread that missing attribute as "stream can't do unicode" and fell back to the ASCII # barLatest release of
tqdmflips that fallback: an encoding-less stream is now treated as unicode-capable, so the captured bar became █ (U+2588) instead of #, breaking the golden-file comparison.