Skip to content

Conversation

@craigscott-crascit
Copy link
Contributor

This allows the user or project to do further processing of the JSON output (e.g. to publish missing binary packages that were built) and to troubleshoot any problems during the install.

Fixes: #706

This allows the user or project to do further processing of the JSON
output (e.g. to publish missing binary packages that were built) and
to troubleshoot any problems during the install.
Comment on lines +38 to +41
# Handling of empty values for single-value keywords with cmake_parse_arguments()
if(POLICY CMP0174)
cmake_policy(SET CMP0174 NEW)
endif()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, we could update the cmake_minimum_required() call above to specify a version range that included up to at least 3.31. But that's a more involved change because it would require checking all policies added after CMake 3.24 up to whatever upper limit was specified. That's a separate focus to this PR, but would be good to do in a follow-up PR.

@craigscott-crascit
Copy link
Contributor Author

I wasn't sure if this needed any documentation changes. It's not currently documented, but if we want it to be officially supported and maintain the location, we could document it. Or we could leave it undocumented initially to give folks who are interested time to try it. If we don't get any negative feedback after 6 months or so, we could make it officially documented then.

@craigscott-crascit
Copy link
Contributor Author

@jcar87 Just checking if there's anything more you need me to do for this before it can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it possible to capture the JSON output of the conan install command(s)

1 participant