Make conan install command copyable#730
Merged
memsharded merged 1 commit intoMay 13, 2026
Merged
Conversation
|
|
When ARGN contains CMake lists, those lists get expanded within quotes. This entails that the semicolons that delimit list items are printed in the log message. To make this log message reflect the actual shell command being ran, we want to strip out those semicolons.
ChrisThrasher
force-pushed
the
copyable_install_command
branch
from
50e0816 to
0d09307
Compare
|
Just tested and this looks to solve my issue, thanks 👍 |
JakeSwartwoutTrimble
approved these changes
May 13, 2026
memsharded
approved these changes
May 13, 2026
Member
|
Looking good, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #729
When ARGN contains CMake lists, those lists get expanded within quotes. This entails that the semicolons that delimit list items are printed in the log message. To make this log message reflect the actual shell command being ran, we want to strip out those semicolons. We do this by joining each list element with spaces to create a new string.