Ensure discovered CMake path is appended correctly - #733
Merged
memsharded merged 1 commit intoJun 5, 2026
Merged
Conversation
|
|
memsharded
approved these changes
Jun 4, 2026
memsharded
left a comment
memsharded
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution @JakeSwartwoutTrimble
Looks good to me
Member
|
It would be necessary to sign the CLA in order to merge it, please check it. Thanks |
When CMake is not already in the path, the directory of the `CMAKE_COMMAND` is stored into `PATH_TO_CMAKE_BIN` to append to the path. Most systems use ":" (colon) as a separator, but on windows the path is separated by ";" (semicolon).
JakeSwartwoutTrimble
force-pushed
the
cmake_path_discovery_fails
branch
from
June 5, 2026 21:40
7bf3bbf to
76aa902
Compare
Contributor
Author
|
Thanks! Looks like I had accidentally put my email in wrong so it wasn't getting linked to my CLA signing, looks to be all good now |
Member
|
Excellent, many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CMake is not already in the path, the directory of the
CMAKE_COMMANDis stored intoPATH_TO_CMAKE_BINto append to the path. Most systems use ":" (colon) as a separator, but on windows the path needs to be separated by ";" (semicolon).Tested that when CMake isn't in my path, it gets added correctly for: