Skip to content

[linter] Fix vs_layout has no folder param. Adds bazel_layout #14966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2022
Merged

[linter] Fix vs_layout has no folder param. Adds bazel_layout #14966

merged 1 commit into from
Dec 27, 2022

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Dec 27, 2022

Related to #14959

bazel_layout is still not documented but it is indeed in conan v2 since https://github.com/conan-io/conan/pull/10812/files

uilianries
uilianries approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot mentioned this pull request Dec 27, 2022
Open
prince-chrismc
prince-chrismc approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/conan-io/conan/blob/7b381791d3c207c0135c8030644f9f9e99e9ddc3/conan/tools/microsoft/layout.py#L7 👍

Whoops, good catch

@conan-center-bot conan-center-bot merged commit f53d2ac into conan-io:master Dec 27, 2022
AbrilRBS pushed a commit to AbrilRBS/conan-center-index that referenced this pull request Jan 16, 2023
@danimtb @AbrilRBS
(conan-io#14966) [linter] Fix vs_layout has no folder param. Adds baz…
94f94f9 
…el_layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
GitHub config
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danimtb @uilianries @prince-chrismc @conan-center-bot