Skip to content

Conversation

@mmomtchev
Copy link

@mmomtchev mmomtchev commented Mar 11, 2024

Specify library name and version: libz/1.3.1

Refs: #23058


@github-actions
Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/zlib//'.

👋 @Hopobcn you might be interested. 😉

@ghost
Copy link

ghost commented Mar 11, 2024

I detected other pull requests that are modifying zlib/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Contributor

Conan v1 pipeline ✔️

All green in build 2 (5d78f1fde30ee09d2562caa7c64cef9e273b02ff):

  • zlib/1.3:
    All packages built successfully! (All logs)

  • zlib/1.3.1:
    All packages built successfully! (All logs)

  • zlib/1.2.13:
    All packages built successfully! (All logs)

  • zlib/1.2.11:
    All packages built successfully! (All logs)

  • zlib/1.2.12:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (5d78f1fde30ee09d2562caa7c64cef9e273b02ff):

  • zlib/1.3.1:
    All packages built successfully! (All logs)

  • zlib/1.2.12:
    All packages built successfully! (All logs)

  • zlib/1.2.11:
    All packages built successfully! (All logs)

  • zlib/1.3:
    All packages built successfully! (All logs)

  • zlib/1.2.13:
    All packages built successfully! (All logs)

@property
def _is_mingw(self):
return self.settings.os == "Windows" and self.settings.compiler == "gcc"
return self.settings.os == "Windows" and self.settings.compiler in ["gcc", "clang"]
Copy link
Contributor

@SpaceIm SpaceIm Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would break clang-cl.

I've proposed a helper in conan client conan-io/conan#12678, but it has been rejected.

You would like something like this:

    @property
    def _is_mingw(self):
        self.settings.os == "Windows" and (self.settings.compiler == "gcc" or (self.settings.compiler == "clang" and not self.settings.compiler.get_safe("runtime")))

See also #14644

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It got rejected because it was a conan 1.x issue. If this is common throughout conan, I think there must be a generic and centralized solution to it. Especially since these days, if someone is using a gcc-derivative on Windows, the most probable choice would be clang because of libc++.

@mmomtchev
Copy link
Author

Should be superseded by the solution to conan-io/conan#15648

@mmomtchev mmomtchev closed this Mar 12, 2024
@mmomtchev mmomtchev deleted the zlib-pkgconfig-name-clang-windows branch March 12, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants