-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[zlib] use the MinGW pkg-config name with clang on Windows #23060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zlib] use the MinGW pkg-config name with clang on Windows #23060
Conversation
|
🤖 Beep Boop! This pull request is making changes to 'recipes/zlib//'. 👋 @Hopobcn you might be interested. 😉 |
|
I detected other pull requests that are modifying zlib/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
| @property | ||
| def _is_mingw(self): | ||
| return self.settings.os == "Windows" and self.settings.compiler == "gcc" | ||
| return self.settings.os == "Windows" and self.settings.compiler in ["gcc", "clang"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would break clang-cl.
I've proposed a helper in conan client conan-io/conan#12678, but it has been rejected.
You would like something like this:
@property
def _is_mingw(self):
self.settings.os == "Windows" and (self.settings.compiler == "gcc" or (self.settings.compiler == "clang" and not self.settings.compiler.get_safe("runtime")))See also #14644
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It got rejected because it was a conan 1.x issue. If this is common throughout conan, I think there must be a generic and centralized solution to it. Especially since these days, if someone is using a gcc-derivative on Windows, the most probable choice would be clang because of libc++.
|
Should be superseded by the solution to conan-io/conan#15648 |
Specify library name and version: libz/1.3.1
Refs: #23058