Skip to content

easyloggingpp: various fixes #27346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chausner
Copy link
Contributor

@chausner chausner commented May 2, 2025

Summary

Changes to recipe: easyloggingpp/9.97.1

Motivation

This fixes a few bugs in the current recipe.

Details

  • Add check for C++11 or higher (the README mentions that the library requires at least C++11)
  • Fix the broken option disable_trace_logs (this previously set the wrong define)
  • Fix the broken option enable_default_logfile (this previously behaved in the opposite way as expected)
  • Add pthread to system libs on Linux/FreeBSD if option enable_thread_safe is enabled (the README mentions that linking with pthread is required in this case)

This PR has been split up from #27261.


Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Only a minor change, otherwise looks good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants