-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fcarouge-kalman: add recipe #27358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fcarouge-kalman: add recipe #27358
Conversation
@FrancoisCarouge I've cleaned up the recipe a bit and removed the creation of samples and tests, it would be great if new releases had a cmake option to disable them so that no patching is needed on our side. Also, I've seen that eigen, gsl and mp::units are downloaded as part of the samples/examples, so my question is if they are ever needed to run the library, or if they are only used as supporting libraries in the examples, thanks! |
Successful compilation/usage logs, as the CI does not compile C++23 packages yet:
|
Thank you for the cleanup @AbrilRBS ! I will be sure to avoid the tests and samples in the next release. I can confirm the eigen, gsl, and mp-units libraries are not required for the library. They are only used in the samples and tests to showcase advanced use cases. They will no longer be downloaded in the next release. I could also verify in your successful compilation/usage logs they are not downloaded under the patch conditions. |
I converted this pull request to draft as I upstream the test and sample avoidance. I will update the pull request to remove the patch with the next version. |
@@ -0,0 +1,7 @@ | |||
cmake_minimum_required(VERSION 3.25) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake_minimum_required(VERSION 3.25) | |
cmake_minimum_required(VERSION 3.15) |
Summary
Adds recipe: fcarouge-kalman/0.5.1
fixes #27357
Motivation
New recipe in support of the Kalman package, for issue #27357 [request] fcarouge-kalman.
Details
Initial recipe support for the C++23 and CMake project.
Tested on Ubuntu 22.04 and MacOS 15.4.1 with GCC14 and Clang 19.