Skip to content

25765: Have assimp use minizip-ng to avoid conflict with openimageio #27361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EstebanDugueperoux2
Copy link
Contributor

Summary

Changes to recipe: lib/[version]

Motivation

Details


@uilianries
Copy link
Member

@EstebanDugueperoux2 Hello 👋 Thank you for taking the time to address this issue.

Unfortunately, we don't have minizip-ng:mz_compatibility=True available in ConanCenter, it's False by default: https://github.com/conan-io/conan-center-index/blob/master/recipes/minizip-ng/all/conanfile.py#L39. The result will be a missing package error when building it in the CI, and users should expect the same when installing Assimp.

As a workaround, you can use replace-requires in your Conan profile:

[replace_requires]
minizip/*: minizip-ng/4.0.7

[options]
minizip-ng/*:mz_compatibility=True

The CMake target name is a bit more complicated, you will need to keep that change in the Assimp recipe, as it affects what is expected by that project. I just checked locally if you could use a conanfile.py with CMakeDeps.set_property to override the cmake_target_name without changing the Assimpt recipe, but it did not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants