-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[WIP] open62541: Add version 1.4.11.1 and option for NodeSetLoader #27372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add support for open62541 version 1.4.11.1. Introduce `nodeset_loader` option in Conan to enable NodesetLoader.
Following this because I have issues with v1.4.6 and this recipe on MinGW, see here Also was working on a recipe that includes 1.3.15, the version that's currently included in open62541pp.
Not sure if there's a policy on adding "older" versions, 1.3.15 is newer than 1.4.6, but older than 1.4.11.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to open the PR, and also for the detailed PR description, we appreciate it
I have some comments about some of the changes, but the diff looks mostly there :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this patch, why can't we just set UA_ENABLE_DEBUG_SANITIZER
to False
to avoid taking this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a version that builds without the patch file here. It builds successfully on my machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that option is available for all 1.4.x
$ git log -S UA_ENABLE_DEBUG_SANITIZER
commit a820093aa97d08334147ecb85d8602f917d4f511
Author: theirix <[email protected]>
Date: Sun Jun 19 14:06:57 2022 +0300
feat(build): add option UA_ENABLE_DEBUG_SANITIZER
$ git tag --contains a820093aa97d08334147ecb85d8602f917d4f511
prev-v1.4.2
v1.4.0
v1.4.0-rc1
v1.4.0-rc2
v1.4.1
v1.4.10
v1.4.11
v1.4.11.1
v1.4.2
v1.4.3
v1.4.4
v1.4.5
v1.4.6
v1.4.7
v1.4.8
v1.4.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a patch file for 1.3.x. The 1.4.11.1 patch file from my sided was initially created to replicate the patching behavior of earlier open62541 recipes.
@ErikTempelaarVO let's move the discussion about the possibility of adding an old version in #27373 :) |
Co-authored-by: Abril Rincón Blanco <[email protected]>
Co-authored-by: Abril Rincón Blanco <[email protected]>
P.S.: checked all the other optionally deleted options, looks like no get_safe() usage is needed for them
Summary
This pull request adds support for version 1.4.11.1 of open62541, introducing a new Conan option for enabling the NodesetLoader feature. This feature allows users to optionally include the NodesetLoader functionality.
Motivation
The addition of the NodesetLoader option allows Conan users to utilize the NodesetLoader feature.
Details
nodeset_loader
to enable or disable the NodesetLoader feature.nodeset_loader
is enabled.Open Questions