-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add release 3.7.0 of opensubdiv #28883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release 3.7.0 of opensubdiv #28883
Conversation
9632dd9 to
6cddbcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! 🙏
LGTM! I changed the .with_metal default value to let macOS have all the binaries without any missing ones, as it's optional
Thanks for proposing that 👏 |
|
Hi @jcar87 @franramirez688 , then you don't approve onetbb requirement by default, as for upstream? |
|
UPDATE: I finally reverted the
Do you mean that you'd like to change the default value to |
|
Thanks for the review and merge. |
Summary
DocumentRef-LICENSE.txt:LicenseRef-Tomorrow-Open-Source-TechnologyPixarAnimationStudios/OpenSubdiv#1376 has been proposed to upstream to avoid patch for future release.
Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!