Skip to content

Conversation

@EstebanDugueperoux2
Copy link
Contributor

@EstebanDugueperoux2 EstebanDugueperoux2 commented Nov 12, 2025

Summary

  • Add opensubdiv/3.7.0 version
  • Add new License name: DocumentRef-LICENSE.txt:LicenseRef-Tomorrow-Open-Source-Technology
  • Do not publish revisions for older versions (< 3.6.0)

PixarAnimationStudios/OpenSubdiv#1376 has been proposed to upstream to avoid patch for future release.


  • Read the contributing guidelines
  • Checked that this PR is not a duplicate: list of PRs by recipe
  • If this is a bug fix, please link related issue or provide bug details
  • Tested locally with at least one configuration using a recent version of Conan

Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!

franramirez688
franramirez688 previously approved these changes Nov 13, 2025
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EstebanDugueperoux2

Thanks for this PR! 🙏

LGTM! I changed the with_metal default value to let macOS have all the binaries without any missing ones, as it's optional.

@franramirez688
Copy link
Contributor

PixarAnimationStudios/OpenSubdiv#1376 has been proposed to upstream to avoid patch for future release.

Thanks for proposing that 👏

AbrilRBS
AbrilRBS previously approved these changes Nov 13, 2025
@EstebanDugueperoux2
Copy link
Contributor Author

Hi @jcar87 @franramirez688 , then you don't approve onetbb requirement by default, as for upstream?

@franramirez688
Copy link
Contributor

UPDATE: I finally reverted the with_metal default value change, so I'll keep the original value 🙏

Hi @jcar87 @franramirez688 , then you don't approve onetbb requirement by default, as for upstream?

Do you mean that you'd like to change the default value to True? If that's the case, I think that it's fine to maintain it asFalse to keep the graph as simple as possible, regardless of upstream.

@franramirez688 franramirez688 merged commit 9b703ed into conan-io:master Nov 13, 2025
8 checks passed
@EstebanDugueperoux2 EstebanDugueperoux2 deleted the feature/AddOpenSubDiv3.7.0 branch November 13, 2025 15:55
@EstebanDugueperoux2
Copy link
Contributor Author

Thanks for the review and merge.
I wanted to enable onetbb because core library alone hasn't much interest.
And for #24506 I need opensubdiv with osdcpu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants