[glad] Fix potential build failure due to missing Jinja package #29247
+19
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planetmarshall
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: glad/2.0.8
Motivation
Simplifies user installation of the Glad package
Details
Occasionally installation of the package can fail if CMake
FindPythondetects a Python installation that does not include the Jinja2 package. As conan's Python executable will always have that dependency, just tell CMake to use the same Python executable as conan. This was already the behaviour on CCI runners, this PR just makes it the default.Also simplify the test package by removing the requirement on CCI.
Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!