[qt] set lib property for plugins#29668
Open
planetmarshall wants to merge 1 commit intoconan-io:masterfrom
Open
[qt] set lib property for plugins#29668planetmarshall wants to merge 1 commit intoconan-io:masterfrom
planetmarshall wants to merge 1 commit intoconan-io:masterfrom
Conversation
planetmarshall
force-pushed
the
qt-fix-plugin-location
branch
from
5903567 to
cc99495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: qt/5.x
Motivation
When using the new CMakeConfigDeps generator, Qt plugins cannot be found by querying, for example,
as they do not have the
libproperty defined whenshared=True(which is typical for Qt), and they end up beingdefined in the generated config files as
INTERFACElibraries.Details
the
libproperty for Qt plugins was only defined forshared=False. This PR defines it unconditionally.Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!