URL encode query strings in art:promote#211
Merged
memsharded merged 2 commits intoconan-io:mainfrom Oct 1, 2025
Merged
Conversation
memsharded
reviewed
Oct 1, 2025
Member
memsharded
left a comment
There was a problem hiding this comment.
This looks good, thanks very much for your contribution @maalund
I think it might be worth to add a test to cover this case, something like:
@pytest.mark.requires_credentials
def test_art_promote_build_version():
conanfile = textwrap.dedent("""
from conan import ConanFile
class Pkg(ConanFile):
name = "mypkg"
version = "1.0+build"
""")
save("./conanfile.py", conanfile)
run("conan create .")
run("conan upload mypkg/1.0+build -c -r extensions-stg")
art_url = os.getenv("ART_URL")
art_user = os.getenv("CONAN_LOGIN_USERNAME_EXTENSIONS_PROD")
art_password = os.getenv("CONAN_PASSWORD_EXTENSIONS_PROD")
run(f"conan art:promote pkglist.json --from=extensions-stg --to=extensions-prod --url={art_url} --user={art_user} --password={art_password}")
out = run("conan list mypkg/1.0+build:*#* -r=extensions-prod -f=json", stderr=None)
remote_prod_list_json_out = json.loads(out)
# check it
# necessary to do 2 promotes to see the error??
out = run("conan list mypkg/1.0+build:*#* -r=extensions-prod -f=json", stderr=None)
remote_prod_list_json_out = json.loads(out)
# check it againwould be good (I haven't tested it)
Member
|
If you're having problemas with the CLA bot, note that the commit might have been authored by a different email than the ones associated with your account, so the CLA bot won't be able to mark it as accepted. The easiest way would be to amend the commit with a valid email author, and force push to get the history clean for the bot |
92bd0c2 to
ce62e4e
Compare
ce62e4e to
3d0d4f0
Compare
Contributor
Author
|
Test added and author amended. |
AbrilRBS
approved these changes
Oct 1, 2025
memsharded
approved these changes
Oct 1, 2025
Member
|
Merged, many thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #210