[art:build-info] Fix timezone issue on timestamp and regex assert#223
Merged
[art:build-info] Fix timezone issue on timestamp and regex assert#223
Conversation
AbrilRBS
reviewed
Nov 26, 2025
| # from here: https://github.com/jfrog/build-info-go/blob/9b6f2ec13eedc41ad0f66882e630c2882f90cc76/buildinfo-schema.json#L63 | ||
| if not re.match(r'^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}.\d{3}(Z|[+-]\d{4})$', formatted_time): | ||
| raise ValueError("Time format does not match BuildInfo required format.") | ||
| assert re.match(r'^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.\d{3}(Z|[+-]\d{4})$', formatted_time), \ |
Member
There was a problem hiding this comment.
Looks good, bit note that upstream has this same bug! https://github.com/jfrog/build-info-go/blob/main/buildinfo-schema.json#L63 shows
^\\d{4}-\\d{2}-\\d{2}T\\d{2}:\\d{2}:\\d{2}.\\d{3}(Z|[+-]\\d{4})$
AbrilRBS
approved these changes
Nov 26, 2025
Member
AbrilRBS
left a comment
AbrilRBS
left a comment
There was a problem hiding this comment.
https://github.com/jfrog/build-info-go/blob/main/README.md?plain=1#L49 the example looks good
czoido
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #219