Add --no-fail-fast option to art:build-info promote#241
Open
deivse wants to merge 1 commit intoconan-io:mainfrom
Open
Add --no-fail-fast option to art:build-info promote#241deivse wants to merge 1 commit intoconan-io:mainfrom
--no-fail-fast option to art:build-info promote#241deivse wants to merge 1 commit intoconan-io:mainfrom
Conversation
Author
|
Here's the relevant part in artifactory docs, confirming the default was |
Member
|
HI @deivse, Thanks a lot for opening a PR. Indeed, your use case sounds reasonable, and the implementation is quite easy as it is something that Artifactory API already supports 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I think this can be very helpful in certain situations. My use case is building on TeamCity with separate build jobs for each OS, and a separate promote job. In such a setup, if a single build job fails, and promote is still ran accidentally, then further promotes will attempt to overwrite existing artifacts unless the account has a delete permission. However, what I really want is to just upload the new stuff and ignore such errors. This allows to treat the promote job as "Promote everything that is new from the latest build job runs" without additional complex logic.
Hopefully this is an acceptable change - it doesn't change the current behaviours, is simple, and can be helpful to some users.