[cpp_info][BazelDeps] Improve auto deduce locations#17296
Merged
czoido merged 15 commits intoconan-io:develop2from Nov 25, 2024
Merged
[cpp_info][BazelDeps] Improve auto deduce locations#17296czoido merged 15 commits intoconan-io:develop2from
czoido merged 15 commits intoconan-io:develop2from
Conversation
franramirez688
commented
Nov 11, 2024
| cc_import( | ||
| name = "libssl_precompiled", | ||
| shared_library = "bin/libcrypto-3-x64.dll", | ||
| shared_library = "bin/libssl-3-x64.dll", |
Contributor
Author
There was a problem hiding this comment.
Actually, it was a bug 😅
franramirez688
commented
Nov 11, 2024
franramirez688
changed the title
czoido
reviewed
Nov 14, 2024
czoido
reviewed
Nov 14, 2024
czoido
reviewed
Nov 14, 2024
czoido
reviewed
Nov 14, 2024
franramirez688
commented
Nov 20, 2024
franramirez688
commented
Nov 20, 2024
memsharded
reviewed
Nov 20, 2024
Member
memsharded
left a comment
memsharded
left a comment
There was a problem hiding this comment.
Looks good a couple of details.
memsharded
reviewed
Nov 21, 2024
memsharded
reviewed
Nov 21, 2024
memsharded
approved these changes
Nov 23, 2024
czoido
approved these changes
Nov 25, 2024
This was referenced Nov 25, 2024
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Improved auto deduce location function.
Changelog: Feature: BazelDeps using the new
deduce_locationmechanism to find the libraries.Changelog: Bugfix: BazelDeps failed to find OpenSSL shared libraries.
Docs: omit
Close: #16990
Close: #16926