fix unzip pattern and strip_root should be used together#17591
Merged
czoido merged 1 commit intoconan-io:develop2from Jan 21, 2025
Merged
fix unzip pattern and strip_root should be used together#17591czoido merged 1 commit intoconan-io:develop2from
czoido merged 1 commit intoconan-io:develop2from
Conversation
franramirez688
approved these changes
Jan 20, 2025
Contributor
franramirez688
left a comment
There was a problem hiding this comment.
LGTM! Thanks a lot for the contribution @jusito
I just suggested a small detail in one of the unittests.
5f52fcd to
c5db575
Compare
franramirez688
approved these changes
Jan 21, 2025
AbrilRBS
approved these changes
Jan 21, 2025
czoido
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Make possible to use
patternandstrip_rootat the same time forconan.tools.files.unzip().Docs: Omit
fixes #14455
Found today that during archive extraction pattern and strip_root can't be used together. Same as in the related issue I would expect that pattern is applied before strip_root but actually they currently can't be used together at all.
developbranch, documenting this one.