Skip to content

[conan list] New parameter --graph-context#18015

Merged
memsharded merged 6 commits intoconan-io:develop2from
franramirez688:frm/list_context
Mar 26, 2025
Merged

[conan list] New parameter --graph-context#18015
memsharded merged 6 commits intoconan-io:develop2from
franramirez688:frm/list_context

Conversation

@franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Mar 25, 2025

Changelog: Feature: Added new --graph-context to conan list command.
Docs: conan-io/docs#4042
Closes: #17971

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, please add some tests.

@franramirez688 franramirez688 marked this pull request as ready for review March 26, 2025 09:24
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better.

for k, v in other.lists.items():
self.lists.setdefault(k, PackagesList()).merge(v)

def keep_outer(self, other):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this processing to be local inside load_graph()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but what about the PackagesList part? Also embedded in the load graph?

@memsharded memsharded merged commit 19dcaa9 into conan-io:develop2 Mar 26, 2025
15 checks passed
@franramirez688 franramirez688 deleted the frm/list_context branch March 26, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[question] quick way to find build-context packages

3 participants