Let backup selection remove unknown refs#18018
Merged
memsharded merged 2 commits intoconan-io:develop2from Mar 25, 2025
Merged
Conversation
AbrilRBS
commented
Mar 25, 2025
|
|
||
| self.client.run("export .") | ||
| self.client.run("upload * -c -r=default") | ||
| assert "No backup sources files to upload" in self.client.out |
Member
Author
There was a problem hiding this comment.
This shows that the upload still ignores the unknown refs (A different message is shown when uploading them)
| assert "No backup sources files to upload" in self.client.out | ||
|
|
||
| self.client.run("cache clean --backup-sources") | ||
| assert len(os.listdir(s_folder)) == 0 |
Member
Author
There was a problem hiding this comment.
And these 2 checks to the s_folder show that we backed the sources in the conan source call, but that conan cache clean removed it, so the unknown ref was picked up
memsharded
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Remove backup sources from unknown refs when calling
conan cache clean.Docs: Omit
Closes #17919