Fix runners after refactor on #17961#18040
Merged
memsharded merged 3 commits intoconan-io:develop2from Mar 28, 2025
Merged
Conversation
davidsanfal
approved these changes
Mar 28, 2025
memsharded
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: omit
Docs: omit
This PR fixes two issues related with conan runners:
An error introduced in organizing cli, moving to api #17961 where an invalid runner instance were being returned instead of a runner class
Make runner tests run again in GitHub actions. This PR Removed intermediate python versions in CI matrix #17839 forced the github job to use a custom docker image instead which does not have enabled docker in docker feature, making pytest to skip all the conan runner tests