-
Notifications
You must be signed in to change notification settings - Fork 370
Add note about editable package pitfall (#4749) #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Onno Broekmans seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
||
.. note:: | ||
|
||
CMake-based consumer projects may not pick up on modifications made to header files in the editable package. In this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this behavior is not specific to CMake, but any build system and working with editable packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, this is the normal (maybe not expected at first try) behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's entirely fair, it's just that I offered to add a note in the documentation in the linked Conan issue.
I think it's enough of a potential trip-up that I figured it could save people troubleshooting time if one would point this out up-front. But feel free to close the PR if you don't think that's necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the note is fine, just make it more generic (it doesn't happen only with header libraries but any other library as well) and is not specific to CMake
This is a tiny update to the documentation, pointing out the small pitfall with editable packages I encountered in conan-io/conan#4749.
I hope this helps! Please do feel free to reject if you feel this is not a good place and/or wording.