Skip to content

Add note about editable package pitfall (#4749) #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

onnodb
Copy link

@onnodb onnodb commented Apr 16, 2019

This is a tiny update to the documentation, pointing out the small pitfall with editable packages I encountered in conan-io/conan#4749.

I hope this helps! Please do feel free to reject if you feel this is not a good place and/or wording.

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Onno Broekmans seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.


.. note::

CMake-based consumer projects may not pick up on modifications made to header files in the editable package. In this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this behavior is not specific to CMake, but any build system and working with editable packages

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, this is the normal (maybe not expected at first try) behavior

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's entirely fair, it's just that I offered to add a note in the documentation in the linked Conan issue.

I think it's enough of a potential trip-up that I figured it could save people troubleshooting time if one would point this out up-front. But feel free to close the PR if you don't think that's necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the note is fine, just make it more generic (it doesn't happen only with header libraries but any other library as well) and is not specific to CMake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants