Skip to content

[reference] Add tools.files.chmod description and reference#4038

Merged
czoido merged 2 commits intoconan-io:develop2from
uilianries:tools/chmod
Mar 31, 2025
Merged

[reference] Add tools.files.chmod description and reference#4038
czoido merged 2 commits intoconan-io:develop2from
uilianries:tools/chmod

Conversation

@uilianries
Copy link
Member

@uilianries uilianries commented Mar 28, 2025

Related to conan-io/conan#17800

It requires Conan develop2 branch to be generated.

Preview - Docs commit 2985991 + Conan commit 63e193b

conan_ref_files_chmod

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@czoido
Copy link
Contributor

czoido commented Mar 28, 2025

If we accept None as value for read, write and execute, shouldn't the type hints be as follows?

read: Optional[bool] = None,
write: Optional[bool] = None,
execute: Optional[bool] = None,

Also, I think that it should be documented in the docstring that True will add the permission, False will remove it and the default that is None does not modify it.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@czoido czoido merged commit 131df50 into conan-io:develop2 Mar 31, 2025
2 checks passed
@czoido czoido removed the request for review from memsharded March 31, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants