Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Add pybind11 to the whitelist for KB-h016 - #145

Open
uilianries wants to merge 3 commits into
conan-io:masterfrom
uilianries:whitelist/pybind11
Open

Add pybind11 to the whitelist for KB-h016#145
uilianries wants to merge 3 commits into
conan-io:masterfrom
uilianries:whitelist/pybind11

Conversation

@uilianries

Copy link
Copy Markdown
Member

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries

Copy link
Copy Markdown
Member Author

@danimtb I just update it. Rather than putting pybind11 in whitelist, now any custom find cmake file is allowed. Take a look.

@uilianries

Copy link
Copy Markdown
Member Author

Seems like the last change related to Python 2.7 affected us. Should we drop the tests involving Python 2.7 ?

@danimtb

danimtb commented Jan 17, 2020

Copy link
Copy Markdown
Member

We are not dropping Python 2 support in the CI yet, please see #146

@uilianries

Copy link
Copy Markdown
Member Author

Restarting in 3 .. 2 .. 1 ..

@uilianries uilianries closed this Jan 27, 2020
@uilianries uilianries reopened this Jan 27, 2020
@danimtb

danimtb commented Apr 28, 2020

Copy link
Copy Markdown
Member

@uilianries please update this PR with the latest changes in master branch to kick the CI

@danimtb

danimtb commented Apr 28, 2020

Copy link
Copy Markdown
Member

Just a note: I am a bit hesitant about the changes in this PR as packages may have other Find*.cmake files to find other libraries. I think we have to make sure that the file is declared in cpp_info.build_modules mandatory, so we are able to see it in the PR diff inside the recipe

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants