-
Notifications
You must be signed in to change notification settings - Fork 2
Migrate to Eslint v9 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
conarti
wants to merge
24
commits into
master
Choose a base branch
from
feat/migrate-to-eslint-9
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First iteration - just migrate 'as is'
Hello! How to solve this issue?
|
@iksent Hello. You have to use |
- Add RULE_NAMES constants to config for better maintainability - Remove utils.ts and move rule naming to config - Simplify create-plugin by removing enhanceWithImportOrder - Remove mergeConfigs dependency - Add import-order rule to main plugin rules - Update all import-order configs to use RULE_NAMES constants - Improve type safety and developer experience 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Create rules/import-order/configs.ts with centralized rule configurations - Remove duplicate configurations from configs/import-order files - Update create-plugin to use direct rule configs instead of extracting from configs - Remove shared.ts as it's no longer needed - Improve DRY principle and maintainability - Ensure single source of truth for import-order rule configurations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Update import-order config names to use proper plugin namespace - Change from @conarti/sort-imports/* to @conarti/feature-sliced/import-order/* - Maintain consistency with plugin naming convention 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! If you’d like to test the new version of the plugin with me, you’re welcome to join. Feel free to report any issues in this PR.
Usage:
npm i -D @conarti/eslint-plugin-feature-sliced@next
eslint.config.js
:Planned tasks before publishing the stable version:
@x
supportpeerDependencies
and check other fields inpackage.json
tseslint.config(...)
factory