[TRACKING] Offline Mode Staging #234
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One more typing fix
Manifest update and more documentation
[#177348535] -- Add optional`force_offline_data=true` query parameter https://www.pivotaltracker.com/story/show/177348535
…te-answers hacky untyped fix for the duplicate answers problem
[#177348535] -- Add optional `__forceOfflineData` query parameter https://www.pivotaltracker.com/story/show/177348535
[#177348535] -- Add optional `__forceOfflineData` query parameter https://www.pivotaltracker.com/story/show/177348535
…offline_data-param Type out query parameter keys, add `force_offline_data` key.
…e-regression Fix merge regression _currentOfflineActivityId → _currentOfflineResourceURL
The 0 status code is returned for opaque responses. Since our fetch based cache filler use the no-cors option we get opaque responses for all external non-cors enabled servers.
…t-plugin-state Save plugin state when exporting student data to JSON
…cache Add 0 as valid cacheable response
these were not found before, perhaps because I didn't go to all of the pages or perhaps this is related to the change that Doug made
This allows the PWA install icon to be seen in the long-lived offline-mode branch
Also added missing tests for offline-manifest-api (minus dexie tests)
…manifest Update site manifest to make start_url and icons relative paths
…st-ordering Added save of manifest name and activity order [#177347793]
Fixed lint errors
# Conflicts: # cypress/integration/opening-reports.test.ts # src/components/activity-completion/completion-page-content.tsx
# Conflicts: # cypress/integration/opening-reports.test.ts # src/components/activity-completion/completion-page-content.tsx
Fix some issues post merge. Add `orderedQuestionsOnPage` helper
Tests for getVisibleEmbeddablesOnPage
PC content v6
Also moved some storage-facade related type declarations to the top of the file. [#177343947] Adding spec tests for storage facade https://www.pivotaltracker.com/story/show/177343947
[#177343947] Adding spec tests for storage facade https://www.pivotaltracker.com/story/show/177343947
…-storage-tests 177343947 add offline storage tests
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
===========================================
- Coverage 85.57% 75.39% -10.18%
===========================================
Files 78 93 +15
Lines 2509 3548 +1039
Branches 610 775 +165
===========================================
+ Hits 2147 2675 +528
- Misses 356 866 +510
- Partials 6 7 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
clean up lint warnings
This makes it easier to test script changes. If --no-fetch-activities is used and --bump-version is not used, then the manifest and activities will be updated in place. The activities will not be fetched, but they might change if the script does modifications that haven't been done already.
…est-updating add support for in place manifest updating
during installing if the cache has a file with a etag that matches the revision in the manifest then don't refetch the file. this became more complicated because of CORS restrictions on reading the etag most of our buckets don't alllow reading this etag from a CORS response
This makes it easier to test. This also adds a test of of cacheUrlsWithProgress This also identifies a potential problems with how we are getting the service worker to send the cache message to To make testing easier this also adds jest-mock-console
this also switches it from typescript to basic javascript Jest 26 does not support transforming environments so typescript doesn't work.
this doesn't yet include a test for a request that is already in the cache
Co-authored-by: Noah Paessel <[email protected]>
…e-list Add revisions to cache list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the intergration branch for offline-mode worker.
The
offline-modebranch is the production branch and will trigger a release to schools if it is modified.So new PRs should be merged into this
offline-mode-devbranch first so they can be tested.