START-4 add playwright #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playwright test results
Details
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
===========================================
+ Coverage 60.00% 70.07% +10.07%
===========================================
Files 1 4 +3
Lines 35 274 +239
Branches 5 11 +6
===========================================
+ Hits 21 192 +171
- Misses 14 82 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tealefristoe
approved these changes
Mar 20, 2025
Contributor
tealefristoe
left a comment
tealefristoe
left a comment
There was a problem hiding this comment.
I had a couple of questions, but overall looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Playwright and remove Cypress.
This started as a simple copy of the changes in concord-consortium/dst-codap-plugin#25.
But I found some problems with that setup:
These problems fixed here, as well as all references to Cypress are removed.
Additionally the runtime code was updated to make it easier for a Playwright test to find the elements in the plugin. The main change was to use
<label>and<output>which makes it easier for Playwright to find the elements and also makes the plugin more accessible.