Skip to content

Conversation

@emcelroy
Copy link
Contributor

@emcelroy emcelroy commented Apr 30, 2025

START-1

Remove environment from .github/workflows/ci.yml and add githubToken and deployRunUrl. This will allow the new version of s3-deploy-action to create a GitHub Deployment and set its log_url property, which will allow Jira to add a deployment link to associated Jira issues.

[START-1](https://concord-consortium.atlassian.net/browse/START-1)

Remove `environment` from `.github/workflows/ci.yml` and add `githubToken` and `deployRunUrl`. This will allow the new version of `s3-deploy-action` to create a GitHub Deployment and set its `log_url` property, which will allow Jira to add a deployment link to associated Jira issues.
@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.07%. Comparing base (9a1676c) to head (a46546f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   70.07%   70.07%           
=======================================
  Files           4        4           
  Lines         274      274           
  Branches       11       11           
=======================================
  Hits          192      192           
  Misses         82       82           
Flag Coverage Δ
jest 62.16% <ø> (ø)
playwright 69.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

Playwright test results

passed  2 passed

Details

report  Open report ↗︎
stats  2 tests across 1 suite
duration  12.2 seconds
commit  a46546f

@emcelroy emcelroy requested a review from scytacki April 30, 2025 02:18
Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@emcelroy emcelroy merged commit 22b17f6 into main May 6, 2025
5 checks passed
@emcelroy emcelroy deleted the START-1-add-deployment-link-to-jira branch May 6, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants