Skip to content

Conversation

@ddamelin
Copy link

@ddamelin ddamelin commented Jul 25, 2025

This is a potential pull request to add French and Dutch to v3. I am unable to build v3 locally so this should be tested before being merged.

@ddamelin ddamelin requested a review from eireland July 25, 2025 23:38
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.80%. Comparing base (41128f7) to head (23e9f5a).
⚠️ Report is 162 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (41128f7) and HEAD (23e9f5a). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (41128f7) HEAD (23e9f5a)
cypress 10 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2045       +/-   ##
===========================================
- Coverage   87.24%   69.80%   -17.44%     
===========================================
  Files         688      688               
  Lines       35533    35534        +1     
  Branches     8289     8658      +369     
===========================================
- Hits        30999    24806     -6193     
- Misses       4524    10111     +5587     
- Partials       10      617      +607     
Flag Coverage Δ
cypress 41.79% <ø> (-30.83%) ⬇️
jest 55.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Jul 25, 2025

codap-v3    Run #8271

Run Properties:  status check passed Passed #8271  •  git commit 23e9f5ab3d: add French and update other languages
Project codap-v3
Branch Review dutch-translation
Run status status check passed Passed #8271
Run duration 01m 55s
Commit git commit 23e9f5ab3d: add French and update other languages
Committer Dan Damelin
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@kswenson kswenson requested review from kswenson and removed request for eireland July 25, 2025 23:42
@kswenson kswenson added the v3 CODAP v3 label Aug 6, 2025
@ddamelin ddamelin changed the title add Dutch and update all other languagues add French and Dutch and update all other languages - v3 Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3 CODAP v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants