-
Notifications
You must be signed in to change notification settings - Fork 44
fix: case table cell tooltips #2289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: CODAP-1072-case-table-elision
Are you sure you want to change the base?
fix: case table cell tooltips #2289
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## CODAP-1072-case-table-elision #2289 +/- ##
=================================================================
+ Coverage 86.55% 86.73% +0.17%
=================================================================
Files 723 723
Lines 38719 38720 +1
Branches 9584 9499 -85
=================================================================
+ Hits 33514 33583 +69
+ Misses 5196 4833 -363
- Partials 9 304 +295
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes tooltip styling for case table cells to ensure the black hover tooltip matches the white hover text, addressing issues with tooltip positioning and sizing.
Changes:
- Removed fixed height constraint from tooltips to allow dynamic sizing
- Added
whiteSpace="pre-wrap"andmaxW="400px"properties for better text wrapping and width control - Changed tooltip data-testid to be unique per cell using row and column identifiers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
CODAP-324-case-table-tooltip
|
| Run status |
|
| Run duration | 08m 08s |
| Commit |
|
| Committer | Kirk Swenson |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
1
|
|
|
48
|
|
|
0
|
|
|
301
|
| View all changes introduced in this branch ↗︎ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
[CODAP-324] Case Table: the black hover tooltip should match the white hover text