Skip to content

Conversation

@eireland
Copy link
Contributor

@eireland eireland commented Apr 28, 2025

Uses GeoNames.org API to grab location names at lat, long.
CODAP Table uses the location name instead of lat, long for label value.

NASAEARTH-2

@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.21%. Comparing base (49c2fc7) to head (90ac09e).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/location-utils.ts 63.63% 8 Missing ⚠️
src/models/data-manager.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   79.41%   79.21%   -0.20%     
==========================================
  Files          25       26       +1     
  Lines        1977     2011      +34     
  Branches      127      114      -13     
==========================================
+ Hits         1570     1593      +23     
- Misses        404      415      +11     
  Partials        3        3              
Flag Coverage Δ
jest 55.50% <18.91%> (-0.79%) ⬇️
playwright 75.53% <75.67%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Apr 28, 2025

Playwright test results

passed  8 passed

Details

report  Open report ↗︎
stats  8 tests across 4 suites
duration  48.2 seconds
commit  90ac09e

Fix broken Playwright test
@eireland eireland marked this pull request as ready for review April 29, 2025 18:20
@eireland eireland requested a review from scytacki April 29, 2025 18:20
Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Perhaps we should wait for feedback from Kate before merging.

@scytacki scytacki added the wontfix This will not be worked on label May 13, 2025
@scytacki
Copy link
Member

After discussion with the team, we've decided to not merge this work. Details about it should be in the Jira issue.

@scytacki scytacki closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants