-
Notifications
You must be signed in to change notification settings - Fork 0
Nasaearth 2 map pin geoname #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 79.41% 79.21% -0.20%
==========================================
Files 25 26 +1
Lines 1977 2011 +34
Branches 127 114 -13
==========================================
+ Hits 1570 1593 +23
- Misses 404 415 +11
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Playwright test resultsDetails
|
Fix broken Playwright test
scytacki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Perhaps we should wait for feedback from Kate before merging.
|
After discussion with the team, we've decided to not merge this work. Details about it should be in the Jira issue. |
Uses GeoNames.org API to grab location names at lat, long.
CODAP Table uses the location name instead of lat, long for label value.
NASAEARTH-2