-
Notifications
You must be signed in to change notification settings - Fork 0
Nasaearth 15 sync pin selection #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dependency error.
BUG: can't deselect cases case once one is selected
Playwright test resultsDetails
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 79.38% 76.23% -3.15%
==========================================
Files 25 25
Lines 1974 2117 +143
Branches 107 135 +28
==========================================
+ Hits 1567 1614 +47
- Misses 404 500 +96
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scytacki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a dependency cycle to fix. Other than that it looks OK.
scytacki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Syncs map pin selection to neo data context case table and vice versa.
Multiple pin or case selection is handled when user does a shift+click.