Skip to content

Conversation

@eireland
Copy link
Contributor

@eireland eireland commented May 9, 2025

Syncs map pin selection to neo data context case table and vice versa.
Multiple pin or case selection is handled when user does a shift+click.

@eireland eireland marked this pull request as ready for review May 9, 2025 18:31
@eireland eireland requested a review from scytacki May 9, 2025 18:31
@github-actions
Copy link

github-actions bot commented May 9, 2025

Playwright test results

passed  8 passed

Details

report  Open report ↗︎
stats  8 tests across 4 suites
duration  45 seconds
commit  0ee5203

@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 48.42105% with 98 lines in your changes missing coverage. Please review.

Project coverage is 76.23%. Comparing base (6fb0626) to head (0ee5203).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/models/plugin-state.ts 48.44% 83 Missing ⚠️
src/utils/codap-utils.ts 44.44% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   79.38%   76.23%   -3.15%     
==========================================
  Files          25       25              
  Lines        1974     2117     +143     
  Branches      107      135      +28     
==========================================
+ Hits         1567     1614      +47     
- Misses        404      500      +96     
  Partials        3        3              
Flag Coverage Δ
jest 53.67% <35.78%> (-2.74%) ⬇️
playwright 72.17% <42.63%> (-3.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a dependency cycle to fix. Other than that it looks OK.

Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@scytacki scytacki merged commit 281b2fe into main May 12, 2025
3 of 5 checks passed
@scytacki scytacki deleted the NASAEARTH-15-sync-pin-selection branch May 12, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants