Skip to content

Conversation

@scytacki
Copy link
Member

@scytacki scytacki commented Jul 15, 2025

  • if a user edits the pin table directly and enters partial or invalid values the plugin should not crash
  • if the user enters longitude value outside the -180 to 180 range it is normalized so the pixel can still be looked up on the rasters.
  • if the user enters a latitude value outside of -90 to 90 it is clamped to be a value in this range.
  • fix running playwright tests when using Node v24. It was failing to find the imported types in the playwright.config.ts, by making them explicit type imports node just ignores them so it doesn't look for them.
  • extract latLongToPixel into a function outside of GeoImage so it is easier to test

- if a user edits the pin table directly and enters partial or invalid values the plugin should not crash
- if the user enters longitude value outside the -180 to 180 range it is normalized so the pixel can still be looked up on the rasters.
- if the user enters a latitude value outside of -90 to 90 it is clamped to be a value in this range.
- fix running playwright tests when using Node v24
- extract latLongToPixel into a function outside of GeoImage so it is easier to test
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.37%. Comparing base (2f86f53) to head (6f5cfee).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/models/plugin-state.ts 73.33% 8 Missing ⚠️
src/models/geo-image.ts 95.55% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   77.18%   77.37%   +0.19%     
==========================================
  Files          26       26              
  Lines        2332     2374      +42     
  Branches      148      130      -18     
==========================================
+ Hits         1800     1837      +37     
- Misses        529      534       +5     
  Partials        3        3              
Flag Coverage Δ
jest 50.39% <60.00%> (+1.27%) ⬆️
playwright 73.79% <85.33%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

Playwright test results

passed  8 passed

Details

report  Open report ↗︎
stats  8 tests across 4 suites
duration  53.9 seconds
commit  6f5cfee

@scytacki scytacki marked this pull request as ready for review July 15, 2025 19:46
@scytacki scytacki requested a review from tealefristoe July 15, 2025 19:48
Copy link
Contributor

@tealefristoe tealefristoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@scytacki scytacki merged commit a580530 into main Jul 16, 2025
5 checks passed
@scytacki scytacki deleted the NASAEARTH-26-robust-pin-lat-long branch July 16, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants