スクロール中の自動更新停止と画面上部へのバッジ表示に対応しました#83
Open
inugamine wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #77
概要
タイムラインをスクロール中に新着投稿が自動挿入されることで閲覧位置がズレる問題を解消します。スクロール中は自動更新を停止し、新着があった場合はタイムライン上部にアバター付きバッジを表示します。
変更内容
変更ファイル（2ファイル）
app/src/components/RealtimeTimeline.tsxweb/src/components/RealtimeTimeline.tsxapp版・web版ともに同一の変更です。
自動更新の停止制御
TimelineReader.haltUpdateを利用し、scrollTop > 100pxまたは新着バッジが表示中の場合に自動挿入を停止haltUpdateフラグを動的に切り替えnewArrivalsRefを併用新着バッジ
TimelineReader.onNewItemコールバックでhaltUpdate中の新着を検知client.getMessage(href)で投稿者のアバター情報を取得し蓄積+Nで表示バッジ操作
newArrivalsクリア +scrollTo(0)+reload()newArrivalsをクリアprops.timelines変更時）にもクリア