-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark vendoring jupyter_scheduler packages as broken #1406
base: main
Are you sure you want to change the base?
Conversation
IMO the rebuilds (to whatever extent that is deemed necessary) should come before marking the existing packages as broken. |
Makes sense. Let's see what the team has to say. My gut feeling is that the three remaining versions is enough. |
@zklaus Can you mark this PR as a draft until we reach a consensus in conda-forge/jupyter_scheduler-feedstock#46? |
Hi everone. As discussed here conda-forge/jupyter_scheduler-feedstock#46 (comment), I've rebuilt latest patch of each minor version >2, <2.8.0. Non-rebuilt 2.x versions < 2.8.0 and all 1.x versions can be marked as broken. Versions I've rebuilt:
Versions OK to be marked as broken:
Thank you for looking into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only mark following versions as broken:
- 2.7.0
- 2.5.1
- 2.5.0
- All 1.x versions
Cross posting from the jupyter_scheduler issue: Thanks for taking care of this, @andrii-i. Much appreciated! Before re-activating the admin request PR, I want to clarify one last thing with you.
We see both 2.7.0 and 2.7.1 show up, but only build number 0 (as you can see from the This is all a long winded way of saying: If we proceed as planned, more things than you listed as "OK to be marked broken" will be marked broken, but I believe the intent of what you want to achieve is matched. |
Guidelines for marking packages as broken:
instead of marking packages as broken. This alternative workflow makes environments more reproducible.
not technically broken and should not be marked as such.
but should be patched in the repo data and be marked unbroken later.
the maintainers only, we can allow packages to be marked broken more liberally.
conda-forge/core
) try to make a decision on these requests within 24 hours.What will happen when a package is marked broken?
broken
label to the package. Themain
label will remain on the package and this is normal.anaconda.org
CDN picks up the new patches, you will no longer be able to install the package from themain
channel.Checklist:
Description
Older builder of jupyter_scheduler vendor a significant number of other, popular packages such as SQLAlchemy and Pydantic, among others.
This happened by accident because the standard, grayskull-provided install script line made pip install dependencies, which slipped through quality control.
The feedstock side is discussed in conda-forge/jupyter_scheduler-feedstock#46, the recipe is fixed to prevent this happening again in the future (though the rebuilds of older versions are still outstanding.
Here, we need to mark the offending builds as broken, which this PR is for.
@conda-forge/jupyter_scheduler, please weigh in as you see fit.